Skip to content

Conversation

urfeex
Copy link
Member

@urfeex urfeex commented Feb 7, 2025

This should give us the possibility to make backwards-compatible changes easier than with the long argument lists that we currently have.

@urfeex urfeex force-pushed the configuration_struct branch 2 times, most recently from 174cca1 to 9771561 Compare February 10, 2025 10:54
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 91.47287% with 11 lines in your changes missing coverage. Please review.

Project coverage is 73.31%. Comparing base (f717f83) to head (2ce3c9b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/ur/ur_driver.cpp 67.64% 9 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   72.50%   73.31%   +0.81%     
==========================================
  Files          80       80              
  Lines        3091     3182      +91     
  Branches      397      398       +1     
==========================================
+ Hits         2241     2333      +92     
+ Misses        634      631       -3     
- Partials      216      218       +2     
Flag Coverage Δ
ur20-latest 72.03% <90.69%> (+0.99%) ⬆️
ur5-3.14.3 72.89% <90.69%> (+1.00%) ⬆️
ur5e-5.9.4 72.65% <90.69%> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urfeex urfeex force-pushed the configuration_struct branch 3 times, most recently from dcb6ea4 to 353ed6a Compare February 10, 2025 16:01
@urfeex urfeex requested a review from a team February 10, 2025 16:01
@urfeex urfeex marked this pull request as ready for review February 10, 2025 16:01
We forward the deprecated setKeepalive method through the UrDriver which
triggers a depracation warning. We disable it (for GCC) for this call.
@urfeex urfeex force-pushed the configuration_struct branch from 5789305 to 2ce3c9b Compare February 11, 2025 11:04
@urfeex urfeex merged commit 97ad825 into UniversalRobots:master Feb 11, 2025
19 of 23 checks passed
@urfeex urfeex deleted the configuration_struct branch February 11, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants