Remove Penn Treebank escaping of brackets... #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use "(" and ")" instead of "-LRB-" and "-RRB-".
amir-zeldes
added a commit
that referenced
this pull request
Jun 9, 2020
* Fixes #88 * Implemented using the following DepEdit script: ``` #no special adverbial status for WH adverb subordinations lemma=/^(when|how|where|while|why|whenever|wherever)$/&func=/mark/&head=/(.*)/&pos=/ADV/ none #1:pos=SCONJ lemma=/^(when|how|where|while|why|whenever|wherever)$/&func=/advmod/&head=/(.*)/ none #1:func=mark;#1:pos=SCONJ;#1:head2=$2:mark #exception for WH adverbs in questions, identified by question mark and not being an advcl func!=/advcl/;lemma=/^(when|how|where|while|why|whenever|wherever)$/&pos=/SCONJ/&func=/mark/&head=/(.*)/;text=/^(\?+)!?$/ #1>#2;#2.*#3 #2:func=advmod;#2:pos=ADV;#2:head2=$2:advmod #exception for 'why not' func=/root/;lemma=/why/&func=/mark/&head=/(.*)/;lemma=/not/\t#1>#2;#2.#3\t#2:func=advmod;#2:pos=ADV;#2:head2=$1:advmod #exception for do support func=/root/;lemma=/^(why|how|when|where)$/&func=/mark/&head=/(.*)/;lemma=/do/\t#1>#2;#2.#3\t#2:func=advmod;#2:pos=ADV;#2:head2=$2:advmod ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and use "(" and ")" instead of "-LRB-" and "-RRB-", as discussed in #1.
I am happy to rebase the pull request at any time, please just write if the UD_English team is ready to pull this.