build(linting): add more lints #537
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
|
Please rework the title of this PR as it's too generic. Saying this because the changelog content will be based on the title of PRs. |
|
Nooo, now we'll have to do proper result handling and such :( |
lol 💀😅. We can still use |
|
Should the actual fixes to the issues uncovered by the lints be in this PR or a separate PR? |
I was considering the same thing 🤔 This PR should be for deciding which lints to add and which to After the decision is made, we can gradually apply the fixes in a separate PR |
|
Should we |
|
@Universal-Debloater-Alliance/developers Please pick this up. See comments/questions above. |
|
I'll merge when I have time (probably in ~3 hours) to fix the warnings in a separate PR |
|
When Rust 1.81 releases on |
* refactor(apply-lints): `cargo clippy --fix` * style: format code with Rustfmt This commit fixes the style issues introduced in 7c04d15 according to the output from Rustfmt. Details: #578 * style(save): call unqualified `Ok` * style(sync): inline fmt args on `info!` * style(theme): properly separate hex colors, `allow` `match_same_arms` * refactor(list-view): `allow` some lints, dedupe text widget * refactor(list-view): fix 1 `if_not_else` * fix(utils): `setup_uad_dir` no longer takes `Option` Also more logging and error handling * refactor(list-view): `export_selection` `Button` built with common branch * fix(list-view): fix all warns in 1 file, refactor, err handling, etc... * style: format code with Rustfmt This commit fixes the style issues introduced in 49cfa27 according to the output from Rustfmt. Details: #578 * refactor(lints): `allow`, `expect`, and apply lints. factor `uad_lists.json` into var Also: - factors-out the List name into a `const`. - Converts some regular comments into docs. - use `reason` as a better alternative to comments. * docs(name): concise description of `NAME` * style(theme): apply suggestion from review --------- Co-authored-by: Rudxain <[email protected]> Co-authored-by: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
https://rust-lang.github.io/rust-clippy/stable/