Make cor prf disable optimizations non immutable #288
Conversation
…y consistently on that module
…sDisabled() instead
…PRF_DISABLE_INLINING
Co-authored-by: Jan Kotas <[email protected]>
|
Closing and moving to other repo |
|
Reopening as I dont have write access in other repo |
| { | ||
| profiler = new ClassLoad(); | ||
| } | ||
| else if (clsid == DynamicJitOptimizations::GetClsid()) |
There was a problem hiding this comment.
@simonferquel did you have the conflict in this file only?
There was a problem hiding this comment.
It is for a test I introduced, change is legit
There was a problem hiding this comment.
yes, the change is perfect!
I was curious about if this was the only conflicting place during backport as you've mentioned the conflicts
| <ProjectReference Include="$(TestSourceDir)Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" /> | ||
| <ProjectReference Include="../common/profiler_common.csproj" /> | ||
| <CMakeProjectReference Include="$(MSBuildThisFileDirectory)/../native/CMakeLists.txt" /> | ||
| <ProjectReference Include="../../tracing/eventpipe/common/eventpipe_common.csproj" /> |
There was a problem hiding this comment.
do we need a dependency on eventpipe_common project?
There was a problem hiding this comment.
Yes, I use it to intercept method loads in the test after requesting JITing of methods and check the optimization level.
There are similar tests in the CoreCLR test code base. Eventpipe_common brings helper to make intercepting events like that easier in tests.
There was a problem hiding this comment.
ah, thanks, I can see the usage of IpcTraceTest
|
re-closing in favor of internal repo |
2 participants
Backport of dotnet#113924