Swap bytes for port number (case 1006506) #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this should be fine. |
joshpeterson
approved these changes
Mar 9, 2018
TautvydasZilys
approved these changes
Mar 9, 2018
|
Actually... I didn't look at the exact change. This will cause a DllNotFoundException, unless explictly added to LibraryLoader on libil2cpp side. Remember, you can't system load libraries dynamically on UWP! |
|
I could also just adjust this to do the endian swap myself, but I prefer to just follow official recommendation in case something changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap bytes for port number as Win32 API returns in network order. Right now on Windows IPGlobalProperties.GetIPGlobalProperties.GetActiveUdpListeners() returns IPEndPoint's all with incorrect ports.
@TautvydasZilys I think this API (ntohs) is fine on UWP and on the minimum Windows versions we support?