Use the Unity PAL for the IL2CPP debugger #855
Conversation
|
@joshpeterson if we're using the PAL for il2cpp now, can we remove the "-win32", "-mac" etc files from the copy scripts, and all that logic about what to include from the builder? |
|
|
||
| if (!addr_info->entries) { | ||
| *result = NULL; | ||
| mono_free_address_info(addr_info); |
There was a problem hiding this comment.
We allocate above with g_new0 I assume this is correct de-allocator?
There was a problem hiding this comment.
Yes, this is the proper way to de-allocate. This code was taken directly from Mono.
|
@mderoy:We're only using the PAL for the debugger now, so we need to keep copying those files for IL2CPP on Mono. |
Change the IL2CPP manager debugger to use the Unity PAL, so the debugger can work on all platforms that IL2CPP supports.
joshpeterson
force-pushed
the
il2cpp-debugger-unity-pal
branch
from
6decd17
to
58faedf
Compare
| guint32 TailLength; | ||
| } TRANSMIT_FILE_BUFFERS; | ||
|
|
||
| #endif |
There was a problem hiding this comment.
Note that I've just had to add this for one of our platforms. It is a bit of a hack, but I think it is acceptable for now, as it gets the build going, and it is only used in a stub method that won't be called anywhere in the debugger code.
|
@joshpeterson whats stopping us from using the pal for il2cpp on mono? its still experimental and we'll need to do it eventually anyway. |
|
We're missing a number of implementations in the Unity PAL now. We could handle them, but it is just a matter of getting the time to do it. |
Change the IL2CPP manager debugger to use the Unity PAL, so the debugger
can work on all platforms that IL2CPP supports.