Work around an Android C++ compiler bug #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncham
reviewed
Feb 16, 2018
| if (s_ErrorMessagesInitialized) | ||
| return; | ||
|
|
||
| s_ErrorMessagesInitialized = true; |
There was a problem hiding this comment.
Nit, this is racy. Ideally we'd take a lock but at very least we should not set s_ErrorMessagesInitialized to true until the end of this initialization.
Although, if we race in that case we'll get exception since you can't add duplicate keys. So, lock?
There was a problem hiding this comment.
Or just put this in static constructor and let runtime handle for you.
The class library code in `GetErrorMessage` exposes a C++ compiler bug on Android in the r13b NDK. We can't easily update the NDK, so instead we will work around the bug by changing the class library code. We don't expect any change in behavior from this change.
joshpeterson
force-pushed
the
workaround-android-compiler-bug
branch
from
b961ad0
to
415dc87
Compare
|
The Mono build is green with the latest changes. |
joncham
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class library code in
GetErrorMessageexposes a C++ compiler bugon Android in the r13b NDK. We can't easily update the NDK, so instead
we will work around the bug by changing the class library code. We don't
expect any change in behavior from this change.
This corrects case 986215.
Release notes:
IL2CPP: Work around a C++ compiler bug in the Android NDK that occurs when obtaining the message from a socket exception.
I'll back port this fix to 2018.1, 2017.3, and 2017.2