Fixes for il2cpp debugger running with Visual Studio for Mac: #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Returning an empty "list" of custom attributes for types, fields, properties, and methods instead of a not-implemented error. * Updating debugger ASSEMBLY_GET_NAME command to use Il2Cpp code for generating the fully qualified name with public key tokens. The Mono code generates invalid strings for the token with the Il2Cpp assembly name data, which will cause the VSfM debug client to disconnect.
ghost
requested review from
joshpeterson
approved these changes
Jan 25, 2018
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
properties, and methods instead of a not-implemented error.
generating the fully qualified name with public key tokens. The Mono
code generates invalid strings for the token with the Il2Cpp assembly
name data, which will cause the VSfM debug client to disconnect.