Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an issue where a pipestream handle may be closed twice (Case 942966) #804

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

mderoy
Copy link

@mderoy mderoy commented Jan 22, 2018

Release Notes: Fixes an issue in the 4.6 mono libraries, which causes pipestream handles to be closed twice, leading to a crash

The PipeStream class has its own Dispose implementation, but it passes a dangerous handle internally to a FileStream, and tells the filestream that it also owns this handle. As a result the finalizer for filestream also closes the handle, which causes problems when the handle has been reused

@mderoy mderoy self-assigned this Jan 22, 2018
@mderoy mderoy requested a review from joncham January 22, 2018 21:33
@mderoy mderoy changed the title Fixes an issue where a pipestream handle may be closed twice (Case 94… Fixes an issue where a pipestream handle may be closed twice (Case 942966) Jan 22, 2018
@mderoy mderoy merged commit 1ad733d into unity-master Jan 22, 2018
@mderoy mderoy deleted the unity-master-fix-namedpipe-crash branch January 25, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants