Support timezones without daylight savings time (Case 943047) #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncham
approved these changes
Jan 18, 2018
| // OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION | ||
| // WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. | ||
| // Michael DeRoy | ||
| // Jonathan Chambers |
| string[] names; | ||
| if (!System.CurrentSystemTimeZone.GetTimeZoneData (1973, out data, out names)) | ||
| string[] names; | ||
| int currentYear = DateTime.UtcNow.Year; |
There was a problem hiding this comment.
No chance of infinite recursion here, right?
There was a problem hiding this comment.
No, looks like DateTime.UtcNow calls into an icall to get the current system time..converts that to ticks and passes it into the DateTime() constructor...should be no chance of recursion, and I'm not seeing it myself.
| DateTime dltStartTime = new DateTime(1, 1, 1).Add(dlt.Start.TimeOfDay); | ||
| DateTime dltEndTime = new DateTime(1, 1, 1).Add(dlt.End.TimeOfDay); | ||
| TimeSpan utcOffsetTS = TimeSpan.FromTicks(data[(int)TimeZoneData.UtcOffsetIdx]); | ||
| char utcOffsetSign = (utcOffsetTS >= TimeSpan.Zero) ? '+' : '-'; |
mderoy
force-pushed
the
unity-master-tz-fix-build
branch
from
eda4275
to
5b817a3
Compare
mderoy
force-pushed
the
unity-master-tz-fix-build
branch
from
5b817a3
to
eee354c
Compare
mderoy
changed the title
mderoy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes: Fixes an issue where certain platforms failed to do time conversions to a user's local timezone