Avoid using BSTR for conversion of a SecureString #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to use BSTR marshaling to convert a SecureString to a string. On some platforms, BSTR marshaling is not implemented, but we still want to be able to convert a SecureString to a string on those platforms. So instead, use Unicode string marshaling.
joncham
reviewed
Dec 14, 2017
| #if MONO | ||
| try | ||
| { | ||
| bstr = Marshal.SecureStringToGlobalAllocUnicode(secureString); |
There was a problem hiding this comment.
Nit, I would not call this variable bstr
joncham
approved these changes
Dec 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to use BSTR marshaling to convert a SecureString to a
string. On some platforms, BSTR marshaling is not implemented, but we
still want to be able to convert a SecureString to a string on those
platforms.
So instead, use Unicode string marshaling.
This helps correct case 947208 from Unity, although the complete fix requires changes in IL2CPP as well. This change has no release notes.