Remove VM_IMAGE macros and IL2CPPMonoImage #735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshpeterson
reviewed
Dec 6, 2017
| @@ -67,9 +67,8 @@ | |||
| #define VM_ARRAY_GET_RANK(arr) il2cpp_array_rank(arr) | |||
| #define VM_ARRAY_BOUND_LENGTH(arr, i) il2cpp_array_bound_length(arr, i) | |||
| #define VM_ARRAY_BOUND_LOWER_BOUND(arr, i) il2cpp_array_bound_lower_bound(arr, i) | |||
| #define VM_IMAGE_GET_NAME(image) il2cpp_image_name(image) | |||
| //Fixme module name as image name seems bad | |||
There was a problem hiding this comment.
I think the module and image always have the same name, so this might be OK.
joshpeterson
approved these changes
Dec 6, 2017
joncham
approved these changes
Dec 6, 2017
|
merged in #746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.