Remove Il2CppMonoType and VM_TYPE Macros #733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncham
approved these changes
Dec 5, 2017
joncham
reviewed
Dec 5, 2017
| @@ -8,7 +8,10 @@ | |||
|
|
|||
| #define IL2CPP_MONO_PUBLIC_KEY_TOKEN_LENGTH 17 | |||
|
|
|||
| typedef struct Il2CppType Il2CppMonoType; | |||
| //Converted to typedef | |||
| #define MonoType Il2CppType | |||
There was a problem hiding this comment.
typedef redefines the type so we must be including the mono headers. Maybe I should stop including those and change to a typedef?
joshpeterson
approved these changes
Dec 6, 2017
mderoy
changed the base branch from
unity-master-staging-header-c-compatible-5
to
unity-master-staging
|
merged in #746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.