Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2021.3: Avoid throwing TypeLoadException for generic 2D arrays (case UUM-34854) #1779

Merged

Conversation

Saiprasad945
Copy link

@Saiprasad945 Saiprasad945 commented Jun 6, 2023

Mono was a bit too aggressive with its TypeLoadException processing, not allowing some valid code in this case. This change applies the fix from:

dotnet/runtime#85828

Bug: https://jira.unity3d.com/browse/UUM-34854
Backport: https://jira.unity3d.com/browse/UUM-34903

  • Should this pull request have release notes?
    • Yes
    • No
  • Do these changes need to be back ported?
    • Yes
    • No
  • Do these changes need to be upstreamed to mono/mono or dotnet/runtime repositories?
    • Yes
    • No

Reviewers: please consider these questions as well! ❤️

Release notes

Fixed UUM-34854 @Saiprasad945 :
Mono: Avoid an incorrect TypeLoadException when a generic type has a field which is a 2D array of itself.

Comments to reviewers
Cherry-pick is [CleanGraft]
PR to Main: #1774
2023.1 PR: #1777
2022.3 PR: #1778

Mono was a bit too aggressive with its TypeLoadException processing, not
allowing some valid code in this case. This change applies the fix from:

dotnet/runtime#85828
@Saiprasad945 Saiprasad945 changed the title Avoid throwing TypeLoadException for generic 2D arrays (case UUM-34854) 2021.3: Avoid throwing TypeLoadException for generic 2D arrays (case UUM-34854) Jun 6, 2023
@Saiprasad945 Saiprasad945 merged commit 0eda197 into unity-2021.3-mbe Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants