forked from mono/mono
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backout https://github.com/Unity-Technologies/bdwgc/pull/52 #1308
Draft
jechter
wants to merge
914
commits into
unity-main
Choose a base branch
from
backout-retry-signals
base: unity-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix warning crash
…ontext OS synchronization context
Update to latest bee (be3d27e00f2f)
Use bokken runner for windows builds
Add Yamato configs
…edore Remove old mono artifact
Add Stevedore.conf
The `IDataContractSurrogate` interface is part of the public API of .NET 4.7.1. In has a method named `ProcessImportedType`, which was not compiled into the unityaot profile. The `ProcessImportedType` method uses types `CodeTypeDeclaration` and `CodeCompileUnit` as parameters. Both of these types are pretty large, and we don't want to compile them into the unityaot profile. So in order to compile the `ProcessImportedType` method method, add empty `CodeTypeDeclaration` and `CodeCompileUnit` types in unityaot (the profile stubber will fill these in properly). This change allows the unstripped unityaot profile work correctly with IL2CPP. It is difficult for the profile stubber to handle this case, because the code in `SurrogateProviderAdapter` is in a facade assembly, which the profile stubber currently ignores.
…nityaot Compile ProcessImportedType in IDataContractSurrogate for unityaot
Specifically, this picks up changes from: https://github.cds.internal.unity3d.com/unity/il2cpp/pull/287 although there are earlier changes that were not synced here as well.
…l2cpp-2 Sync the debugger agent code from IL2CPP
Add yamato trigger
Use actual stack fault address rather than relying on the SP of the current frame. If we try to enter a method with a large prolog (many locals) we may try to allocate more stack than is available, however the SP has not been updated. This means the stack overflow heuristic to free up enough space may fail, as the used stack may be smaller than the amount of stack that was attempted to be unwound.
…ssions Don't re-zip artifact
Publish mbe to unity-internal
…1280 mono debugger remove some asserts and fixing an error for async debug of a generic (fixes case 1241280)
…1344 Adding check to avoid processing pdbs that have zero sequence points …
…5903 [runtime] Magic interfaces requires the complex stelemref to handle a…
* update bdwgc * Expose mono_gc_start_incremental_collection API * switch bdwgc repo back to unity-master branch
…-array-marking-stack-limit Avoid exceeding the mark stack limit (case 1235202)
…ng 32bit so we don't want to do this by default anymore.
…sx-buildserver-only only build 32bit osx on build server. Catalina doesn't support buildi…
When we have the following sequence: ldloc n ldfld valuetype [Unity.Mathematics]Unity.Mathematics.int2 Foo::bar and local n is a reference to value, when walking the instructions in mono_method_to_ir, we generally try to avoid loading a whole value type just to load one of the fields. I believe this is an optimization. The test here is not quite complete, though, as we have ref valuetypes where the object stored at the location is actually an address, in which case we still need to treat it as we would a normal reference. This optimization isn't present in the ldloc.n coded forms and is written in a slightly more robust way in ldloc.s, so no changes are necessary there. As an alternative to this commit, we might adopt the ldloc.s test for ldloc as well, or merge in mono@29428d9/mono/mini/method-to-ir.c from master which encapsulates much the same intent.
Same method that ldloc.s uses, which incorporates the byref test.
…ono_unity_gc_disable`/`mono_unity_gc_is_disabled` (#1302)
…-x64jit-fix Valuetype ref return x64jit fix
…null-ip Gather callstack even if instruction pointer is null.
Update readme
…3373) * [debugger] Fixing two crashes while debugging an Android app. -> Doing stepping into in VSM in some situation the frame saved in TLS is not synchronised with what is really been executed in the main thread. This makes the debugger-agent crashes because it tries to get variable info in some memory that is not available anymore. -> To fix it I forced the update of stack when CMD_THREAD_GET_FRAME_INFO is called. -> Doing step over in Visual Studio for Windows, if you have the threads debugger window enabled, VSW calls frame_commands for each thread that is showed, and if the thread is not really_suspended it tries to get variable info from a memory that is not available anymore because the thread is not suspended yet. -> To fix it I don't send variable info of a frame if the thread is not really_suspended and doesn't have an async_state valid. Cherry-picked with some light massaging by Alex Thibodeau (case 1249172)
…9172 [debugger] Fixing two crashes while debugging an Android app. (mono#13373) (unity case 1249172)
This change applies a similar fix for exFAT partitions as was applied for FAT32 partitions earlier. For exFAT partitions, the invalid inode value seems to be 1 though.
Correct file sharing for exFAT partitions on macOS (case 1253812)
Joshua Peterson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.