Implement a ReadString overload (case 1106236) #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the `XmlSerializationReader` class, the `ReadString(string, bool)` overload was not implemented in the Mono class library implementation used for the unityaot profile. The implementation used for the unityjit profile from the reference source implements this method. I've copied the implementation from the reference source code here into the code used for the unityaot profile.
|
I manually ran the build here: https://gitlab.cds.internal.unity3d.com/vm/mono/pipelines/13884 It succeeded. |
joncham
approved these changes
Dec 11, 2018
|
I'll back port this fix to 2018.3 as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
XmlSerializationReaderclass, theReadString(string, bool)overload was not implemented in the Mono class library implementation used
for the unityaot profile. The implementation used for the unityjit
profile from the reference source implements this method.
I've copied the implementation from the reference source code here into
the code used for the unityaot profile.
Release notes:
Mono: Implement XmlSerializationReader.ReadString(string, bool) in the profile used for AOT builds. (case 1106236)