Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a ReadString overload (case 1106236) #1101

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

joshpeterson
Copy link

@joshpeterson joshpeterson commented Dec 11, 2018

In the XmlSerializationReader class, the ReadString(string, bool)
overload was not implemented in the Mono class library implementation used
for the unityaot profile. The implementation used for the unityjit
profile from the reference source implements this method.

I've copied the implementation from the reference source code here into
the code used for the unityaot profile.

Release notes:

Mono: Implement XmlSerializationReader.ReadString(string, bool) in the profile used for AOT builds. (case 1106236)

In the `XmlSerializationReader` class, the `ReadString(string, bool)`
overload was not implemented in the Mono class library implementation used
for the unityaot profile. The implementation used for the unityjit
profile from the reference source implements this method.

I've copied the implementation from the reference source code here into
the code used for the unityaot profile.
@joshpeterson
Copy link
Author

I manually ran the build here:

https://gitlab.cds.internal.unity3d.com/vm/mono/pipelines/13884

It succeeded.

@joshpeterson
Copy link
Author

I'll back port this fix to 2018.3 as well.

@joshpeterson joshpeterson merged commit e1b2f98 into unity-master Dec 12, 2018
@joshpeterson joshpeterson deleted the implement-read-string branch December 12, 2018 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants