[Release 18] Update versions and links #5414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
commented
Jun 2, 2021
chriselion
commented
Jun 2, 2021
chriselion
commented
Jun 2, 2021
| @@ -85,7 +85,7 @@ def update_pip_install_line(line, package_verion): | |||
| match = PIP_INSTALL_PATTERN.search(line) | |||
| if match is not None: # if there is a pip install line | |||
| package_name = match.group("package") | |||
| quiet_option = match.group("quiet") | |||
| quiet_option = match.group("quiet") or "" | |||
There was a problem hiding this comment.
Maybe there's a better way to do this with the capture in the regex, but I think this works too.
added 2 commits
June 2, 2021 20:13
dongruoping
approved these changes
Jun 3, 2021
chriselion
pushed a commit
that referenced
this pull request
Jun 9, 2021
chriselion
pushed a commit
that referenced
this pull request
Jun 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
pre-commit run validate-release-links-py --all-filesto update doc links to use the new tagUnreleasedsection in the changelogutils/validate_release_links.pythat causedNonein pip commands.release_N_docsinstead ofrelease_NTypes of change(s)
Checklist