Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GridSensorComponent bug #5270

Merged
merged 2 commits into from
Apr 15, 2021
Merged

Fix GridSensorComponent bug #5270

merged 2 commits into from
Apr 15, 2021

Conversation

dongruoping
Copy link
Contributor

Proposed change(s)

GridSensorComponent.CreateSensors accidentally created m_Sensors as local variable and not actually storing the sensor.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Ruo-Ping Dong added 2 commits April 15, 2021 11:27
@dongruoping dongruoping requested a review from chriselion April 15, 2021 18:38
@dongruoping dongruoping merged commit 128b3c4 into main Apr 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-gridsensor-bug branch April 15, 2021 20:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants