Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Group Manager to soccer/retrain with POCA #5115

Merged
merged 5 commits into from
Mar 15, 2021

Conversation

andrewcoh
Copy link
Contributor

Proposed change(s)

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@@ -280,7 +280,7 @@ you would like to contribute environments, please see our
- Goal:
- Get the ball into the opponent's goal while preventing the ball from
entering own goal.
- Agents: The environment contains four agents, with the same Behavior
- Agents: The environment contains two different Multi Agent Groups with two agents in each.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we have to call out explicitly the implementation here. We can just say "The environment contains two opposing groups of agents, each with two agents."

Copy link
Contributor

@dongruoping dongruoping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewcoh andrewcoh merged commit 450e522 into main Mar 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-groupman-soccer branch March 15, 2021 22:37
ervteng pushed a commit that referenced this pull request Mar 16, 2021
) (#5121)

* Integrate Group Manager to soccer/retrain with POCA (#5115)

* Add Soccer env to changelog

Co-authored-by: andrewcoh <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants