Skip to content

fix: tools metrics dispatcher related memory leak [Backport] #3428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025
Merged

fix: tools metrics dispatcher related memory leak [Backport] #3428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db586e0
fix: memory leak without domain reload
NoelStephensUnity Apr 25, 2025
b44446e
Update CHANGELOG.md
NoelStephensUnity Apr 25, 2025
db633d1
Update CHANGELOG.md
NoelStephensUnity Apr 25, 2025
8910dbe
Merge branch 'develop' into fix/tools-metrics-dispatcher-memory-leak-…
NoelStephensUnity Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.netcode.gameobjects/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Additional documentation and release notes are available at [Multiplayer Documen

### Fixed

- Fixed memory leaks when domain reload is disabled. (#3428)
- Fixed issues with the `NetworkBehaviour` and `NetworkVariable` length safety checks. (#3415)
- Fixed issue where during a `NetworkObject`'s spawn if you instantiated, spawned, and parented another network prefab under the currently spawning `NetworkObject` the parenting message would not properly defer until the parent `NetworkObject` was spawned. (#3403)
- Fixed issue where in-scene placed `NetworkObjects` could fail to synchronize its transform properly (especially without a `NetworkTransform`) if their parenting changes from the default when the scene is loaded and if the same scene remains loaded between network sessions while the parenting is completely different from the original hierarchy. (#3388)
Expand Down
3 changes: 3 additions & 0 deletions com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1303,6 +1303,9 @@ private void OnDestroy()
{
Singleton = null;
}
#if UNITY_EDITOR
EditorApplication.playModeStateChanged -= ModeChanged;
#endif
}

// Command line options
Expand Down