fix: AnticipatedNetworkVariable not updating previous value [MTTB-1036] #3306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
added
the
port:1.x-needed
NoelStephensUnity
added
the
port:1.x-completed
EmandM
approved these changes
Feb 25, 2025
…updating-previousvalue
…updating-previousvalue
NoelStephensUnity
deleted the
fix/anticipatednetworkvariable-not-updating-previousvalue
branch
NoelStephensUnity
added a commit
that referenced
this pull request
Feb 25, 2025
…6] (back port) (#3322) Back-port of #3306. This fixes the issue where the `AnticipatedNetworkVariable` previous value was never updated on the non-authority/write permission instances when the `OnAuthoritativeValueChanged` callback was invoked. [MTTB-1036](https://jira.unity3d.com/browse/MTTB-1036) <!-- Add RFC link here if applicable. --> ## Changelog - Fixed: Issue where the `AnticipatedNetworkVariable` previous value was never updated on the non-authority/write permission instances when the `OnAuthoritativeValueChanged` callback was invoked. ## Testing and Documentation - Includes integration test `NetworkVariableAnticipationTests.PreviousValueIsMaintainedProperly`. - No documentation changes or additions were necessary. <!-- Uncomment and mark items off with a * if this PR deprecates any API: ### Deprecated API - [ ] An `[Obsolete]` attribute was added along with a `(RemovedAfter yyyy-mm-dd)` entry. - [ ] An [api updater] was added. - [ ] Deprecation of the API is explained in the CHANGELOG. - [ ] The users can understand why this API was removed and what they should use instead. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the
AnticipatedNetworkVariableprevious value was never updated on the non-authority/write permission instances when theOnAuthoritativeValueChangedcallback was invoked.MTTB-1036
Back port: #3322
Changelog
AnticipatedNetworkVariableprevious value was never updated on the non-authority/write permission instances when theOnAuthoritativeValueChangedcallback was invoked.Testing and Documentation
NetworkVariableAnticipationTests.PreviousValueIsMaintainedProperly.