Skip to content

fix: distribute parented children distributing with root parent #3203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 10, 2025
Merged

fix: distribute parented children distributing with root parent #3203

merged 10 commits into from
Feb 10, 2025

Conversation

@NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Jan 14, 2025 •
edited
Loading

This fixes an issue with distributing parented children that have the distributable and/or transferrable permissions set and have the same owner as the root parent, that has the distributable permission set, were not being distributed to the same client upon the owning client disconnecting when using a distributed authority network topology.

Changelog

  • Fixed: Issue with distributing parented children that have the distributable and/or transferrable permissions set and have the same owner as the root parent, that has the distributable permission set, were not being distributed to the same client upon the owning client disconnecting when using a distributed authority network topology.

Testing and Documentation

  • Includes integration test ParentChildDistibutionTests.
  • Public documentation for rules to object distribution with parented NetworkObjects: PR-1423

@NoelStephensUnity
fix
e796f22 
This is the initial fix for distributing parented children that have the distributable and/or transferrable permissions set and have the same owner as the root parent, that has the distributable permission set, upon the owning client disconnecting when using a distributed authority network topology.
@NoelStephensUnity
update
f8eaa5c 
Adding initial change log entry.
@NoelStephensUnity
update
148e867 
adding PR number to entry
@NoelStephensUnity
update
ef30290 
Handle check for parent earlier.
Add additional comment details.
@michalChrobot michalChrobot added stat:awaiting-triage Status - Awaiting triage from the Netcode team. and removed stat:awaiting-triage Status - Awaiting triage from the Netcode team. labels Jan 16, 2025
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review February 5, 2025 14:31
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner February 5, 2025 14:31
@NoelStephensUnity
Merge branch 'develop-2.0.0' into fix/distribute-parented-children-wi…
2c40772 
…th-root-parent
@NoelStephensUnity
fix
9d57559 
Adding DAHost side object hierarchy redistribution when a client disconnects.
Adding a DA specific work around for integration testing when instantiating and spawning a player within the test runner scene.
@NoelStephensUnity
test
d6723b9 
The test to validate these changes using a DAHost.
@NoelStephensUnity
style
3e7f1f0 
Removing white spaces
@NoelStephensUnity
test
9f88b59 
Adding ownership locking to the test.
@NoelStephensUnity NoelStephensUnity mentioned this pull request Feb 10, 2025
Merged
3 tasks
@NoelStephensUnity NoelStephensUnity merged commit c369bfd into develop-2.0.0 Feb 10, 2025
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/distribute-parented-children-with-root-parent branch February 10, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmandM EmandM EmandM approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NoelStephensUnity @EmandM @michalChrobot