Skip to content

fix: scene loading event not synchronizing in scene objects #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 11, 2024
Merged

fix: scene loading event not synchronizing in scene objects #3096

merged 4 commits into from
Oct 11, 2024

Conversation

@NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 11, 2024

When a session owner performs a SceneEventType.Load it would cull out all in-scene placed NetworkObjects since the service is not considered an observer.

MTT-9189

Changelog

  • Fixed: Issue with service not getting synchronized with in-scene placed NetworkObject instances when a session owner starts a SceneEventType.Load event.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

@NoelStephensUnity
fix
61c4dc1 
This fixes the issue with in-scene placed NetworkObjects not being synchronized properly when the session owner generates a scene event type load. The service is not considered an observer and when sending a scene event type load it should send all spawned objects.
@NoelStephensUnity
update
677994c 
adding changelog entry
@NoelStephensUnity
update
db77862 
adding associated PR to changelog entry
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review October 11, 2024 16:59
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 11, 2024 16:59
@NoelStephensUnity
update
129a7bf 
covering synchronization too.
@NoelStephensUnity NoelStephensUnity merged commit e9b7ef4 into develop-2.0.0 Oct 11, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/scene-loading-event-not-synchronizing-in-scene-objects branch October 11, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NoelStephensUnity