Skip to content

fix: NetworkManager instantiate & destroy notifications and player spawn prefab offset #3088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 8, 2024
Merged

fix: NetworkManager instantiate & destroy notifications and player spawn prefab offset #3088

merged 8 commits into from
Oct 8, 2024

Conversation

@NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 7, 2024 •
edited
Loading

Small PR to:

  • Provide instantiate and destroy notifications for NetworkManager
  • Fixed an issue with a recently merged PR (not yet released) where the default player prefab's position and rotation would not be used when spawning.

Changelog

  • Added: A static NetworkManager.OnInstantiated event notification to be able to track when a new NetworkManager instance has been instantiated.
  • Added: A static NetworkManager.OnDestroying event notification to be able to track when an existing NetworkManager instance is being destroyed.

Testing and Documentation

  • Includes integration test.
  • Documentation additions to public site are necessary (added to internal tracking).

@NoelStephensUnity
update
a81bdf1 
Adding OnInstantiated and OnDestroying events to NetworkManager in order to provide the ability to know when a new NetworkManager instance has been instantiated and is being destroyed.
@NoelStephensUnity
update
27e578c 
Fixing an issue where a player would not spawn with its default network prefab instance's position and rotation settings.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review October 8, 2024 17:20
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 8, 2024 17:20
@NoelStephensUnity NoelStephensUnity mentioned this pull request Oct 8, 2024
Merged
@NoelStephensUnity
test
3b7ae1d 
Adding validation test
@NoelStephensUnity
update
b583021 
adding changelog entries
@NoelStephensUnity
style
8d389e8 
Adding CR between Added and entries.
@NoelStephensUnity
fix
efc37c4 
Fixing player spawn position for client-server.
@NoelStephensUnity
test
a6ca62e 
The validation test to validate the player's spawn position will be the prefab's offset if no other values are specified.
@NoelStephensUnity
style
15e30c8 
removing using directive not needed.
@NoelStephensUnity NoelStephensUnity merged commit 87d23e9 into develop-2.0.0 Oct 8, 2024
24 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/networkmanager-instantiatedestroy-notifications-and-playerspawn-prefab-offset branch October 8, 2024 22:52
@NoelStephensUnity NoelStephensUnity mentioned this pull request Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NoelStephensUnity