fix: hidden objects from newly promoted session owner still synchronize with newly joining clients #3051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
deleted the
fix/networkshow-networkhide-distributed-authority
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where a
NetworkObjecthidden from a client that is later promoted to a session owner will still get synchronized with newly connecting clients. The authority/owner of theNetworkObjectwill synchronize the newly joined client once the client is finished with the initial session owner synchronization.MTTB-391
Changelog
NetworkObjecthidden from a client that is then promoted to be session owner was not being synchronized with newly joining clients.Testing and Documentation
ExtendedNetworkShowAndHideTests.HiddenObjectPromotedSessionOwnerNewClientSynchronizes