fix: post 2.0.0-pre.2 fixes and updates #2962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updating changelog and package.json * adding date
* fix this fixes the issue where a quaternion could potentially be close to 1.0 but off by a very very very small amount. Under this scenario, we Normalize the quaternion prior to invoking MoveRotation.
…ll references, and removal of animator component requirement (#2957) * update This contains the updates for PR-2820 (Anticipated NetworkVariable and NetworkTransform) with minor adjustments based on updates in the v2.0.0 branch. Updating the package version. Adding updated changelog entries. up-port of PR-2872 up-port of PR-2874. updating change log file
NoelStephensUnity
changed the title
NoelStephensUnity
changed the title
…ene-management-disabled
…ene-management-disabled
NoelStephensUnity
deleted the
fix/2.0.0-pre.2-scene-synch-with-scene-management-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NGO v2.0.0-pre.2 Issues Fixed
Cannot be merged until either:
=or=
Distributed Authority Network Topology Specific
Synchronizing With Scene Management Disabled:
If scene management was disabled and a late joining client connected, the session owner would still try to synchronize the client which would lead to a "Key not found" exception.
Spawning NetworkObject Before Approved
If a session owner attempted to spawn a NetworkObject immediately upon the initial service connection being established, it would allow you to spawn a NetworkObject that was owned by the service which is not a valid spawned object.
NGO (Any Network Topology)
Spawning NetworkObject Within NetworkBehaviour.OnNetworkSessionSynchronized
If you spawn a
NetworkObjectwithin an overriddenNetworkBehaviour.OnNetworkSessionSynchronizedmethod, you would get a list changed exception.NGO v1.x Up-Port
Added support for byte on NetworkVariable through codegen
This is an up-port of #2953
Changelog
[GenerateSerializationForType(typeof(byte))]to both theNetworkVariableandAnticipatedNetworkVariableclasses to assure a byte serializer is defined.NetworkObjectprior to being approved. Now, an error message is logged and theNetworkObjectwill not be spawned prior to the client being approved.NetworkBehaviour.OnInSceneObjectsSpawnedandNetworkBehaviour.OnNetworkSessionSynchronizednotifications would throw a collection modified exception.Testing and Documentation
NetworkObjectSpawning.