Rebase unity bro exe onto master #3
Open
+166
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in progress reconstruction of Unity-Technologies@5a6d5d9 after rebasing onto master and some work not being able to be carried over
Reconstruction of google@1a16703
…Have CMake build a fat x86_64;arm64 executable for MacOS commit Reconstruction of google@bc8750a
|
Before overwriting the old branch, it would be good to test the new Brotli against Unity web builds with brotli compression enabled. |
@juj Is there a difference between what you're saying here and the testing method I outlined in the PR description? |
|
Ah right, no the description in the PR comment reads great. 👍 |
Initialize comment as it was throwing a seg fault since it was uninitialized
brendan-duncan
approved these changes
Oct 13, 2023
@brendan-duncan that's okay, thanks for reviewing it. This work is on hold anyways while I work on some higher pri tickets. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon approval and being merged, this branch should replace unity_bro_exe
This PR is for taking our commits from the unity_bro_exe branch and applying them to the updated version of brotli (our master branch is already in sync with the updated version of brotli, and purposely excludes these Unity specific commits). The branch unity_bro_exe is the one that we reference in the editor as the brotli executable.
I did the following to test the changes:
I only tested this on Mac so far, I plan to test on Windows but will reach out to QA for help testing Linux. Decompression fallback should also be tested.
These are the brotli builds I generated with my changes (step 2 above):