Skip to content

fixed IndexOutOfRangeException on XRLineRenderer.SetPosition() #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixed IndexOutOfRangeException on XRLineRenderer.SetPosition() #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c122068
fixed: OutOfRangeException when calling SetPosition with index 0 on l…
i-xt Nov 26, 2020
18c7c28
Merge branch 'main' into main
i-xt Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Runtime/XRLineRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,14 @@ public void SetPosition(int index, Vector3 position)
var prevIndex = (index - 1 + m_Positions.Length) % m_Positions.Length;
var endIndex = (index + 1) % m_Positions.Length;

if (index > 0 || m_Loop)
if (index > 0)
{
m_XRMeshData.SetElementPipe((index * 2) - 1, ref m_Positions[prevIndex], ref m_Positions[index]);
}
else if (m_Loop)
{
m_XRMeshData.SetElementPipe((m_Positions.Length * 2) - 1, ref m_Positions[prevIndex], ref m_Positions[index]);
}

m_XRMeshData.SetElementPosition(index * 2, ref m_Positions[index]);
if (index < (m_Positions.Length - 1) || m_Loop)
Expand Down