Skip to content

Perforce plugin is hitting the 260-char path limitation in Windows#20

Closed
juliomaqueda wants to merge 6 commits intomasterfrom
fix/1003508_260-char-path-limitation-exeeded-on-windows
Closed

Perforce plugin is hitting the 260-char path limitation in Windows#20
juliomaqueda wants to merge 6 commits intomasterfrom
fix/1003508_260-char-path-limitation-exeeded-on-windows

Conversation

@juliomaqueda
Copy link
Contributor

@juliomaqueda juliomaqueda commented Feb 12, 2024

Purpose of this PR

The Perforce Plugin fails at performing Version Control operations over paths that go over 260 characters on Windows environments, even if long paths are enabled.

Michel Salvado provided a patch that fixes the issue by updating the project to:

  • Windows SDK 10
  • Toolset v142
  • P4 api r19.1 with open ssl 1.0.2

Besides that, we needed to create a new Bokken image to build the project under the updated system requirements.


Testing status

Manual Tests:

  • Verified that plugins work in the Editor.
  • Ran local tests on your machine.

Automated Tests:

  • Perforce tests passing in Yamato for Windows, macOS and Linux.

Yamato:
https://unity-ci.cds.internal.unity3d.com/project/421/branch/fix%2F1003508_260-char-path-limitation-exeeded-on-windows

Copy link
Contributor

@SRombautsU SRombautsU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only fear was dropping support of Windows 7
Apparently this is all good for Unity 2023.1 (but not before!) https://forum.unity.com/threads/increasing-system-requirements-for-windows-editor-in-2023-1-and-dropping-support-for-windows-7.1355966/

So we would have to be careful not trying to patch the Perforce "native" plugin in 2022, or use dedicated branches from now on etc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants