Fix all warnings in a Windows build. #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few code changes fixed warnings, removed debug info for release builds, and added condition for copying .pbd which is not present in a release build.
Contributor
|
Please check your email. I've replied to the message from you and Steen. |
Contributor
|
I am going to integrate the warning fixes as part of #25 I disagree about removing the PDB from the release build, as this is a good opportunity to keep the symbols for debugging later on a production environment, or analyze a callstack in case of crash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few code changes fixed warnings, removed debug info for release builds, and added condition for copying .pbd which is not present in a release build.
Purpose of this PR
Hundreds of warnings were generated during a build. Some required code changes.
Testing status
Couldn't get tests to work. Installed Perforce server, but tests couldn't locate server files. Couldn't find test documentation.
Comments to reviewers
@ignas2 Can you review this, and/or let me know how to run the tests?
11/02 8:30 AM PT Still waiting to hear from Fernando, who you referred me to, and who was emailed on 10/28.
11/03 4:12 AM PT Email from Fernando that it will be reviewed as soon as possible.