Skip to content

Conversation

@sebastienlagarde
Copy link
Contributor

@sebastienlagarde sebastienlagarde commented Jun 14, 2020

Purpose of this PR

Follow up of #893 but for Unlit shader this time

  • Few fix. Unlit.shader and SG Unlit wasn't in sync.

Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

@sebastienlagarde sebastienlagarde merged commit 1c4599f into master Jun 15, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/factor-template-shader-graph-code branch June 15, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants