Add Virtual texturing support for HDRP [Skip CI]

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,42 +1,21 @@
-### **Please read**
-**PR workflow guidelines**
-* SRP ABV will start automatically on Yamato when you open your PR
-* Changes to docs and md files will **not** trigger ABV jobs 
-* Consider making use of **draft PRs** if you are not 100% sure that your PR is ready for review
-* ABV will restart if you add a new commit to a branch with an open PR (hence why you should consider using draft PRs)
-* Adding [skip ci] (case insensitive) to the title of PRs will stop any jobs being trigger automatically - you will need to open Yamato and find your branch to run ABV
-* You can also add [skip ci] to commit messages to prevent CI from running on that push
-* Add [cancel old ci] to your commit message if you've made changes you want to test and no longer need the previous jobs
+**Guide** : https://github.com/Unity-Technologies/Graphics/blob/pr-template-correction/.github/pr-read.png.md
 
-### Checklist for PR maker
-- [ ] Have you added a backport label (if needed)? For example, the `need-backport-*` label. After you backport the PR, the label changes to `backported-*`.
-- [ ] Have you updated the changelog? Each package has a `CHANGELOG.md` file.
-- [ ] Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR.
-- [ ] Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.
+**Display Addon** : https://userstyles.org/styles/182991/unity-graphics-pr-readme
 
----
-### Purpose of this PR
-Why is this PR needed, what hard problem is it solving/fixing?
+# Purpose of this PR
 
----
-### Testing status
+> Why is this PR needed, what hard problem is it solving/fixing?
 
-**Manual Tests**: What did you do?
-- [ ] Opened test project + Run graphic tests locally
-- [ ] Built a player
-- [ ] Checked new UI names with UX convention
-- [ ] Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
-- [ ] C# and shader warnings (supress shader cache to see them)
-- [ ] Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
-- Other: 
+# Testing status
+## Manual Tests
+> What have you tested?
 
-**Automated Tests**: What did you setup? (Add a screenshot or the reference image of the test please)
+## Automated Tests
+> What did you setup? (Add a screenshot or the reference image of the test please)
 
-**Yamato**: (Select your branch):
-https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics
+## Links
+**Yamato**: (Select your branch) https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics
+> Any test projects or documents to go with this to help reviewers?
 
-Any test projects to go with this to help reviewers?
-
----
-### Comments to reviewers
-Notes for the reviewers you have assigned.
+# Comments to reviewers
+> Notes for the reviewers you have assigned.

.github/pr-read-override.css

@@ -0,0 +1,6 @@
+.pull-discussion-timeline>div:first-child>div:first-child .js-previewable-comment-form::before, .new-pr-form .js-previewable-comment-form::before
+{
+    display:block;
+    content: url("https://github.com/Unity-Technologies/Graphics/blob/pr-template-correction/.github/pr-read.png?raw=true");
+    height: auto;
+}

.github/pr-read.png.css

@@ -0,0 +1,26 @@
+@import "github.css";
+
+#write{
+	max-width: none;
+    width: 709px;
+  	margin: 0 auto;
+  	padding: 5px;
+	border: 20px solid #bda668;
+	min-height: auto !important;
+}
+#write > ul:first-child,
+#write > ol:first-child{
+    margin-top: 0px;
+}
+
+body > *:first-child {
+    margin-top: 0 !important;
+}
+body > *:last-child {
+    margin-bottom: 0 !important;
+}
+
+h1, h2, h3, h4, h5, h6
+{
+	width: auto !important;
+}

.github/pr-read.png.md

@@ -0,0 +1,20 @@
+# Please read
+## PR workflow guidelines
+- Consider making use of **draft PRs** if you are not 100% sure that your PR is ready for review
+- Adding [skip ci] (case insensitive) to the title of PRs will stop any jobs being triggered automatically - you will need to open Yamato and find your branch to run ABV
+- You can also add [skip ci] to commit messages to prevent CI from running on that push
+- Add [cancel old ci] to your commit message if you've made changes you want to test and no longer need the previous jobs
+
+## Reminders
+- Have you added a backport label (if needed)?
+
+  > *For example, the `need-backport-*` label. After you backport the PR, the label changes to `backported-*`.*
+- Have you updated the changelog?
+
+  > *Each package has a `CHANGELOG.md` file.*
+- Have you updated or added the documentation for your PR?
+
+  > *When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR.*
+- Have you added a graphic test for your PR (if needed)?
+
+  > *When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.*

.yamato/upm-ci-hdrp.yml

@@ -13,8 +13,8 @@ platforms:
   - name: Win
     os: windows
     type: Unity::VM::GPU
-    image: sdet/gamecode_win10:stable
-    flavor: b1.large
+    image: graphics-foundation/win10-dxr:latest
+    flavor: b1.xlarge
     components:
       - editor
       - il2cpp
@@ -75,7 +75,7 @@ linux_apis:
     type: Unity::VM
     {% else %}
     type: {{ platform.type }}
-    #model: rtx2080
+    model: rtx2080
     {% endif %}
     image: {{ platform.image }}      
     flavor: {{ platform.flavor }}
@@ -225,17 +225,19 @@ All_{{ project.name }}_{{ editor.version }}:
   {% elsif platform.name == "OSX_Metal" %}
   #skip
   {% elsif platform.name == "Linux" %}
-  #skip
-
+  #skip  
   {% elsif platform.name == "Win" %}
+
   {% for win_api in win_apis %}
-  {% if win_api.name == "Vulkan" %}
-  #skip
-  {% elsif  win_api.name == "DX12" %}
-  #skip
-  {% else %}
+    {% if win_api.name == "Vulkan" and testplatform.name == "playmode XR" %}
+    #skip - Vulkan don't support VR
+    {% elsif win_api.name == "Vulkan" and testplatform.name == "editmode" %}
+    #skip - not needed, cover by dx11
+    {% elsif win_api.name == "DX12" and testplatform.name == "editmode" %}
+    #skip - not needed, cover by dx11	
+    {% else %}
     - .yamato/upm-ci-{{ project.name | downcase }}.yml#{{ project.name }}_{{ platform.name }}_{{ win_api.name }}_{{ testplatform.name }}_{{ editor.version }}
-  {% endif %}
+    {% endif %}
   {% endfor %}
 
   {% else %}

.yamato/upm-ci-universal.yml

@@ -94,7 +94,6 @@ android_apis:
     flavor: b1.large
     type: Unity::VM::GPU
     image: sdet/gamecode_win10:stable
-  skip_checkout: true
   variables:
     UPM_REGISTRY: https://artifactory-slo.bf.unity3d.com/artifactory/api/npm/upm-candidates
     {% if editor.version == 'CUSTOM-REVISION' %}
@@ -105,7 +104,7 @@ android_apis:
     - pip install unity-downloader-cli --extra-index-url https://artifactory.internal.unity3d.com/api/pypi/common-python/simple --upgrade
 
     - cd TestProjects/{{ project.folder }} && unity-downloader-cli --source-file ../../unity_revision.txt {% for component in platform.components %}-c {{ component }} {% endfor %}--wait --published-only
-
+    - cd Tools && powershell -command ". .\Unity.ps1; Set-ScreenResolution -width 1920 -Height 1080"
     - cd TestProjects/{{ project.folder }} && utr\utr {{ testplatform.args }}Windows64 --artifacts_path=test-results --timeout=1200 --player-load-path=../../players --player-connection-ip=auto
   artifacts:
     logs:
@@ -234,7 +233,6 @@ Build_{{ project.name }}_OSX_OpenGLCore_Player_{{ editor.version }}:
     - pip install unity-downloader-cli --extra-index-url https://artifactory.internal.unity3d.com/api/pypi/common-python/simple --upgrade
 
     - cd TestProjects/{{ project.folder }} && unity-downloader-cli --source-file ../../unity_revision.txt {% for component in platform.components %}-c {{ component }} {% endfor %}--wait --published-only
-
     - cd TestProjects/{{ project.folder }} && utr/utr {{ testplatform.args }}OSX --testproject=. --editor-location=.Editor --artifacts_path=test-results --timeout=1200 --player-load-path=players --player-connection-ip=auto
   dependencies:
     - path: .yamato/z_editor.yml#editor:priming:{{ editor.version }}:{{ platform.os }}
@@ -308,7 +306,6 @@ Build_{{ project.name }}_OSX_OpenGLCore_Player_{{ editor.version }}:
 
     - ssh -i ~/.ssh/id_rsa_macmini -o "StrictHostKeyChecking=no" bokken@$BOKKEN_DEVICE_IP '/Users/bokken/Library/Python/3.7/bin/unity-downloader-cli --source-file ~/Graphics/unity_revision.txt {% for component in platform.components %}-c {{ component }} {% endfor %}--wait --published-only'
 
-
     {% if testplatform.name == "Standalone" %}
     - |
       ssh -i ~/.ssh/id_rsa_macmini -o "StrictHostKeyChecking=no" bokken@$BOKKEN_DEVICE_IP 'cd ~/Graphics/TestProjects/{{ project.folder }} && ~/Graphics/TestProjects/{{ project.folder }}/utr/utr {{ testplatform.args }}OSX  --testproject=/Users/bokken/Graphics/TestProjects/{{ project.folder }} --editor-location=/Users/bokken/.Editor --artifacts_path=/Users/bokken/Graphics/TestProjects/{{ project.folder }}/test-results --timeout=1400'

LocalTestProjects/HDRP_DebugCrossFade_Tests/Packages/manifest.json

@@ -15,7 +15,7 @@
     "com.unity.render-pipelines.core": "file:../../../com.unity.render-pipelines.core",
     "com.unity.render-pipelines.high-definition": "file:../../../com.unity.render-pipelines.high-definition",
     "com.unity.shadergraph": "file:../../../com.unity.shadergraph",
-    "com.unity.test-framework": "1.0.13",
+    "com.unity.test-framework": "1.1.14",
     "com.unity.testframework.graphics": "file:../../../com.unity.testframework.graphics",
     "com.unity.testing.hdrp": "file:../../../com.unity.testing.hdrp",
     "com.unity.textmeshpro": "2.0.1",

TestProjects/HDRP_DXR_Tests/Packages/manifest.json

@@ -13,8 +13,8 @@
     "com.unity.render-pipelines.high-definition": "file:../../../com.unity.render-pipelines.high-definition",
     "com.unity.render-pipelines.high-definition-config": "file:../LocalPackages/com.unity.render-pipelines.high-definition-config",
     "com.unity.shadergraph": "file:../../../com.unity.shadergraph",
-    "com.unity.test-framework": "1.1.11",
-    "com.unity.testframework.graphics": "7.1.12-preview",
+    "com.unity.test-framework": "1.1.14",
+    "com.unity.testframework.graphics": "7.1.13-preview",
     "com.unity.testing.hdrp": "file:../../../com.unity.testing.hdrp",
     "com.unity.textmeshpro": "3.0.0-preview.1",
     "com.unity.timeline": "1.2.6",

TestProjects/HDRP_PerformanceTests/Packages/manifest.json

@@ -8,8 +8,8 @@
     "com.unity.render-pipelines.high-definition-config": "file:../../../com.unity.render-pipelines.high-definition-config",
     "com.unity.shaderanalysis": "file:../../../com.unity.shaderanalysis",
     "com.unity.shadergraph": "file:../../../com.unity.shadergraph",
-    "com.unity.test-framework.build": "0.0.1-preview.3",
-    "com.unity.test-framework": "1.1.11",
+    "com.unity.test-framework.build": "0.0.1-preview.12",
+    "com.unity.test-framework": "1.1.14",
     "com.unity.test-framework.performance": "2.0.8-preview",
     "com.unity.testing.graphics-performance": "file:../../../com.unity.testing.graphics-performance",
     "com.unity.ugui": "1.0.0",