Skip to content

Fix for sampling garbage outside of screen with low res transparent upsample and dynamic resolution #6957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Fix for sampling garbage outside of screen with low res transparent upsample and dynamic resolution #6957

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
470832b
Fix
FrancescoC-unity Feb 2, 2022
fed9de7
changelog
FrancescoC-unity Feb 2, 2022
e1934da
Merge branch 'hd/bugfix' into HDRP/fix-lowres-sample-out-of-screen
sebastienlagarde Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed custom pass name being cut when too long in the inspector.
- Fixed vertex color mode Add name whicgh was misleading, renamed to AddSubstract.
- Fixed screen space shadow when multiple lights cast shadows.
- Fixed issue with dynamic resolution and low res transparency sampling garbage outside of the render target.

## [14.0.0] - 2021-11-17

Expand Down
4 changes: 3 additions & 1 deletion com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/UpsampleTransparent.shader
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ Shader "Hidden/HDRP/UpsampleTransparent"
#if DEBUG_EDGE
return float4(0.0, 10.0, 0.0, 1.0);
#else
return SAMPLE_TEXTURE2D_X_LOD(_LowResTransparent, s_point_clamp_sampler, ClampAndScaleUVForPoint(nearestUV), 0);
// Important note! The reason we need to do ClampAndScaleUVForBilinear is because the candidate for nearestUV are going to be the ones
// used for bilinear. We are using the same UVs used for bilinear -hence the uv clamp for bilinear- it is just the filtering that is different.
return SAMPLE_TEXTURE2D_X_LOD(_LowResTransparent, s_point_clamp_sampler, ClampAndScaleUVForBilinear(nearestUV), 0);
#endif
}
#else // BILINEAR
Expand Down