Skip to content

Fix missing depth on overlay camera DoF #6549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 9, 2021
Merged

Fix missing depth on overlay camera DoF #6549

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cd397ac
Metal HDRP ref screenshots update (#6507)
sebastienlagarde Dec 7, 2021
b66c806
Fix typo in comment.
eh-unity Dec 7, 2021
d27cf10
Fix overlay depth.
eh-unity Dec 7, 2021
c2e3067
Add test case.
eh-unity Dec 7, 2021
15b6a00
Fix missing depth for overlay DoF. Workaround MacOS depth as wirefram…
eh-unity Dec 8, 2021
3bb95d5
Revert bug workaround. It's in another PR.
eh-unity Dec 9, 2021
9f082ab
Revert "Add test case."
eh-unity Dec 9, 2021
41c4ecb
Edit changelog.
eh-unity Dec 9, 2021
b945ffb
Merge branch 'universal/staging' into universal/fix-overlay-dof
phi-lira Dec 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...s/Assets/ReferenceImages/Linear/OSXPlayer/Metal/None/004-CloudsFlaresDecals.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions .../Assets/ReferenceImages/Linear/OSXEditor/Metal/None/1705_Decals-stress-test.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...ects/HDRP_Tests/Assets/ReferenceImages/Linear/OSXEditor/Metal/None/2551_SSR.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...ts/ReferenceImages/Linear/OSXEditor/Metal/None/9601_SkinnedMeshBatching-Off.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...ets/ReferenceImages/Linear/OSXEditor/Metal/None/9602_SkinnedMeshBatching-On.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 1 addition & 2 deletions com.unity.render-pipelines.universal/Runtime/UniversalRenderPipeline.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,6 @@ static void InitializeAdditionalCameraData(Camera camera, UniversalAdditionalCam
if (isOverlayCamera)
{
cameraData.requiresOpaqueTexture = false;
cameraData.postProcessingRequiresDepthTexture = false;
}

Matrix4x4 projectionMatrix = camera.projectionMatrix;
Expand Down Expand Up @@ -969,7 +968,7 @@ static void InitializeRenderingData(UniversalRenderPipelineAsset settings, ref C
mainLightCastShadows = (mainLightIndex != -1 && visibleLights[mainLightIndex].light != null &&
visibleLights[mainLightIndex].light.shadows != LightShadows.None);

// If additional lights are shaded per-pixel they cannot cast shadows
// If additional lights are shaded per-vertex they cannot cast shadows
if (settings.additionalLightsRenderingMode == LightRenderingMode.PerPixel)
{
for (int i = 0; i < visibleLights.Length; ++i)
Expand Down