Skip to content

Conversation

@gmitrano-unity
Copy link
Contributor

@gmitrano-unity gmitrano-unity commented Nov 29, 2021

Purpose of this PR

This commit reverses an unintentional change to the scene view's
handling of the render scale setting. This change was introduced
in #6274.

This commit also attempts to consolidate some of the render scale logic
in URP's code by modifying the shader constant logic to query the scaled
camera dimensions directly from the camera target descriptor rather than
calculating them again.

Testing status

What has been tested

  • Tested locally that the scene view no longer scales with Render Scale on URP Viking Village

What needs testing

  • Test in a standalone build that render scale still works as intended.
  • Test both when rendering normally as well as having a camera render to a RenderTexture

This commit reverses an unintentional change to the scene view's
handling of the render scale setting. This change was introduced
in #6274.

This commit also attempts to consolidate some of the render scale logic
in URP's code by modifying the shader constant logic to query the scaled
camera dimensions directly from the camera target descriptor rather than
calculating them again.
@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@gmitrano-unity gmitrano-unity marked this pull request as ready for review November 29, 2021 17:10
@gmitrano-unity gmitrano-unity requested review from a team as code owners November 29, 2021 17:10
@ellioman ellioman requested review from a team and removed request for a team November 30, 2021 16:26
@phi-lira
Copy link
Contributor

phi-lira commented Dec 9, 2021

Talked with @ernestasKupciunas , we will merge this one to staging and then test it there.

@phi-lira phi-lira changed the base branch from master to universal/staging December 9, 2021 09:17
@phi-lira phi-lira merged commit a5fae02 into universal/staging Dec 9, 2021
@phi-lira phi-lira deleted the urp/render-scale-scene-view-fix branch December 9, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants