Skip to content

Conversation

@gmitrano-unity
Copy link
Contributor

Purpose of this PR

This change adds a small comment to the URP PostPro tests which explains
the reasoning for an assert related to mixed lighting.


Testing status

Comment only changes

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@gmitrano-unity gmitrano-unity marked this pull request as ready for review November 22, 2021 20:32
@gmitrano-unity gmitrano-unity requested review from a team as code owners November 22, 2021 20:32
Copy link
Contributor

@pbbastian pbbastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying the code! 👍

This change adds a small comment to the URP PostPro tests which explains
the reasoning for an assert related to mixed lighting.
@phi-lira phi-lira changed the base branch from master to universal/staging December 7, 2021 08:25
@phi-lira phi-lira merged commit 940ad3d into universal/staging Dec 7, 2021
@phi-lira phi-lira deleted the urp/postpro-comments branch December 7, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants