Skip to content

Revert Automatic Intermediate Texture handling #6275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 9, 2021
Merged

Revert Automatic Intermediate Texture handling #6275

merged 3 commits into from
Dec 9, 2021

Conversation

@pbbastian
Copy link
Contributor

@pbbastian pbbastian commented Nov 12, 2021

Purpose of this PR

This PR reverts #5297 due to compatibility issues.

@github-actions
Copy link

github-actions bot commented Nov 12, 2021

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%2Fall-lightmapping.yml%23PR_Lightmapping_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@pbbastian pbbastian marked this pull request as ready for review November 17, 2021 12:46
@pbbastian pbbastian requested review from a team as code owners November 17, 2021 12:46
@pbbastian pbbastian requested a review from lukaschod November 17, 2021 12:46
@pbbastian
Copy link
Contributor Author

pbbastian commented Nov 18, 2021 •
edited
Loading

🟢 001_SimpleCube_RenderPass is failing, but is also failing on master.

phi-lira
phi-lira approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@phi-lira phi-lira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Main convern I think this will pass package validation on master but will fail on backport PR.

@phi-lira phi-lira changed the base branch from master to universal/staging December 9, 2021 08:51
@phi-lira phi-lira merged commit 5b3af78 into universal/staging Dec 9, 2021
@phi-lira phi-lira deleted the universal/revert-intermediate-texture-mode branch December 9, 2021 08:51
@phi-lira phi-lira mentioned this pull request Dec 9, 2021
Merged
@pbbastian pbbastian restored the universal/revert-intermediate-texture-mode branch January 11, 2022 09:57
@pbbastian pbbastian deleted the universal/revert-intermediate-texture-mode branch January 11, 2022 10:07
@pbbastian pbbastian mentioned this pull request Jan 11, 2022
Closed
@thomas-zeng
Copy link
Contributor

thomas-zeng commented Jan 25, 2022

Hello Peter,
I was checking the recent master lately and figured the auto intermediate texture handling logic is reverted. This brings the intermediate RT back when the render feature is being used in URP. I am curious about what compatibility issue we were running into with the auto handling logic?

thomas-zeng added a commit that referenced this pull request Feb 9, 2022
@thomas-zeng
Revert "Revert Automatic Intermediate Texture handling (#6275)"
5b6e4f2 
This reverts commit 5b3af78.

# Conflicts:
#	com.unity.render-pipelines.universal/Runtime/UniversalRendererData.cs
@thomas-zeng thomas-zeng mentioned this pull request Feb 9, 2022
Merged
phi-lira pushed a commit that referenced this pull request Feb 16, 2022
@thomas-zeng
Add intermediate texture mode back without changing the old behavior …
1c44c48 
…for compatibility purpose. (#7077)

* Revert "Revert Automatic Intermediate Texture handling (#6275)"

This reverts commit 5b3af78.

# Conflicts:
#	com.unity.render-pipelines.universal/Runtime/UniversalRendererData.cs

* * Updated the default behavior for IntermediateTextureMode. Now URP project sets the mode to Always by default assuming no render feature support rendering directly to back buffer. User could manually set this mode to Auto for better performance.

* * Added yflip handling in SSAO.

* Updated to use RTHandle instead of render target identifier.
PaulDemeulenaere pushed a commit that referenced this pull request Feb 16, 2022
@thomas-zeng @PaulDemeulenaere
Add intermediate texture mode back without changing the old behavior …
d63ca4a 
…for compatibility purpose. (#7077)

* Revert "Revert Automatic Intermediate Texture handling (#6275)"

This reverts commit 5b3af78.

# Conflicts:
#	com.unity.render-pipelines.universal/Runtime/UniversalRendererData.cs

* * Updated the default behavior for IntermediateTextureMode. Now URP project sets the mode to Always by default assuming no render feature support rendering directly to back buffer. User could manually set this mode to Auto for better performance.

* * Added yflip handling in SSAO.

* Updated to use RTHandle instead of render target identifier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukaschod lukaschod Awaiting requested review from lukaschod

1 more reviewer

@phi-lira phi-lira phi-lira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

universal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pbbastian @thomas-zeng @phi-lira