Skip to content

[URP] make the Vulkan RenderTexture MSAA support fallback work in the same way as the swapchain backend implementation #6180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 10, 2021
Merged

[URP] make the Vulkan RenderTexture MSAA support fallback work in the same way as the swapchain backend implementation #6180

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
25a43c5
made the Vulkan MSAA support fallback behaviour behave in the same wa…
manuele-bonanno Nov 1, 2021
ded1309
added comments to the Vulkan MSAA fallback code
manuele-bonanno Nov 1, 2021
c7904be
Added changelog entry
manuele-bonanno Nov 1, 2021
71259ce
Merge branch 'universal/staging' into urp/vulkan_mali_msaa_fix
phi-lira Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions com.unity.render-pipelines.universal/Runtime/UniversalRenderPipelineCore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,6 +572,13 @@ static RenderTextureDescriptor CreateRenderTextureDescriptor(Camera camera, floa
desc.bindMS = false;
desc.useDynamicScale = camera.allowDynamicResolution;

if (SystemInfo.graphicsDeviceType == GraphicsDeviceType.Vulkan)
{
int requestedMsaaSamples = desc.msaaSamples;
if (requestedMsaaSamples == 2 && SystemInfo.GetRenderTextureSupportedMSAASampleCount(desc) == 1)
desc.msaaSamples = 4;
}

// check that the requested MSAA samples count is supported by the current platform. If it's not supported,
// replace the requested desc.msaaSamples value with the actual value the engine falls back to
desc.msaaSamples = SystemInfo.GetRenderTextureSupportedMSAASampleCount(desc);
Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.universal/Runtime/UniversalRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1125,7 +1125,7 @@ bool CanCopyDepth(ref CameraData cameraData)

// copying depth on GLES3 is giving invalid results. Needs investigation (Fogbugz issue 1339401)
if (SystemInfo.graphicsDeviceType == GraphicsDeviceType.OpenGLES3)
msaaDepthResolve = false;
return false;

return supportsDepthCopy || msaaDepthResolve;
}
Expand Down