Skip to content

Conversation

@tomzig16
Copy link
Contributor

Purpose of this PR

Our android devices in the yamato will get an update soon. This PR prepares needed reference image updates. I have ran tests on updated devices so this PR contains all the changes that are needed.

In general, only Terrain, 035 speed tree is updated due to small rasterisation differences, which is not a bug. Everything else seems to be working just fine.


Testing status

Yamato


Comments to reviewers

Devices are not updated yet. I will hold this PR as a draft and open it when we will have new devices in the URP.

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://unity-ci.cds.internal.unity3d.com/project/902/
Search for your PR branch using the search bar at the top, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

URP
/jobDefinition/.yamato%252Fall-urp.yml%2523PR_URP_trunk
With changes to URP packages, you should also run
/jobDefinition/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

@tomzig16 tomzig16 requested a review from phi-lira November 10, 2021 09:06
@tomzig16 tomzig16 marked this pull request as ready for review November 10, 2021 09:06
@tomzig16 tomzig16 requested review from a team as code owners November 10, 2021 09:06
@phi-lira phi-lira changed the base branch from master to universal/staging November 10, 2021 09:46
@phi-lira phi-lira merged commit 8cb82bf into universal/staging Nov 10, 2021
@phi-lira phi-lira deleted the urp/android/prepare-ref-images-for-new-firmware branch November 10, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants