Skip to content

Conversation

@anisunity
Copy link
Contributor

@anisunity anisunity commented Sep 13, 2021

https://fogbugz.unity3d.com/f/cases/1364456/
The emissive contribution was killed by the RTSSS. The emissive contribution will be slightly lower with RTSSS as we multiply it by the diffuse signal in the RTSSS case.

Testing status
2021-09-13_15-42-59

@github-actions
Copy link

Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed.
Link to Yamato: https://yamato.cds.internal.unity3d.com/jobs/902-Graphics
Search for your PR branch using the sidebar on the left, then add the following segment(s) to the end of the URL (you may need multiple tabs depending on how many packages you change)

HDRP
/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk
With changes to HDRP packages, you should also run
/.yamato%252Fall-lightmapper.yml%2523PR_LightMapper_trunk

Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure.

Copy link
Contributor

@remi-chapelain remi-chapelain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been discussed and new behavior has been "pair-validated" ✔️
Officially, we still don't support it (hence the doc), but the behavior will still work for most scenarios, so still an improvement.

@anisunity anisunity marked this pull request as ready for review September 15, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants