-
Notifications
You must be signed in to change notification settings - Fork 860
Fixed Bug That Prevented Sclera Iris Blend node from being added #5375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The Sclera Iris Blend node had the same name as the Sclera Limbal Ring node, so when you selected the Sclera Iris Blend node from the Create Node menu, the Sclera Limbal Ring node was added instead. This made it impossible to add a Sclera Iris Blend node to the graph.
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
anisunity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
jessebarker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The Sclera Iris Blend node had the same name as the Sclera Limbal Ring node, so when you selected the Sclera Iris Blend node from the Create Node menu, the Sclera Limbal Ring node was added instead. This made it impossible to add a Sclera Iris Blend node to the graph.
* Merge Hd/bugfix #5255 * Merge Hd/bugfix #5306 * Fixed Bug That Prevented Sclera Iris Blend node from being added (#5375) The Sclera Iris Blend node had the same name as the Sclera Limbal Ring node, so when you selected the Sclera Iris Blend node from the Create Node menu, the Sclera Limbal Ring node was added instead. This made it impossible to add a Sclera Iris Blend node to the graph. * Merge Hd/bugfix #5427 * Fix compilation issue * Update MotionVectorVertexShaderCommon.hlsl Co-authored-by: bencloward <[email protected]>
The Sclera Iris Blend node had the same name as the Sclera Limbal Ring node, so when you selected the Sclera Iris Blend node from the Create Node menu, the Sclera Limbal Ring node was added instead. This made it impossible to add a Sclera Iris Blend node to the graph.
Purpose of this PR
Fixed the name field of the Sclera Iris Blend node so that it can be added to a graph via the Create Node menu.
Testing status
After making this change, I was able to add the node correctly in my local branch.
Comments to reviewers
Notes for the reviewers you have assigned.