Skip to content

Bugfix 1358480: Fixed missing tooltip for "Tessellation Mode" #5365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Bugfix 1358480: Fixed missing tooltip for "Tessellation Mode" #5365

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1fcd65
- fixed missing "Tessellation Mode" tooltip
JarkkoUnity Aug 17, 2021
f1130b2
- update changelog
JarkkoUnity Aug 17, 2021
e035632
- updated "Tessellation Mode" tooltip
JarkkoUnity Aug 23, 2021
1d6c061
Merge branch 'hd/bugfix' into hd/bugfix-1358480
sebastienlagarde Aug 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed the volumetric clouds having no control over the vertical wind (case 1354920).
- Fixed case where the SceneView don't refresh when using LightExplorer with a running and Paused game (1354129)
- Fixed wrong ordering in FrameSettings (Normalize Reflection Probes)
- Fixed missing tooltip for "Tessellation Mode"

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
5 changes: 2 additions & 3 deletions ...y.render-pipelines.high-definition/Editor/Material/UIBlocks/TessellationOptionsUIBlock.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ internal class Styles
{
public static GUIContent header { get; } = EditorGUIUtility.TrTextContent("Tessellation Options");

public static string tessellationModeStr = "Tessellation Mode";
public static readonly string[] tessellationModeNames = Enum.GetNames(typeof(TessellationMode));

public static GUIContent tessellationText = new GUIContent("Tessellation Options", "Tessellation options");
Expand All @@ -32,7 +31,7 @@ internal class Styles

// Shader graph
public static GUIContent tessellationEnableText = new GUIContent("Tessellation", "When enabled, HDRP active tessellation for this Material.");
public static GUIContent tessellationModeText = new GUIContent("Tessellation Mode", "Specifies the method HDRP uses to tessellate the mesh.");
public static GUIContent tessellationModeText = new GUIContent("Tessellation Mode", "Specifies the method HDRP uses to tessellate the mesh. None uses only the Displacement Map to tessellate the mesh. Phong tessellation applies additional Phong tessellation interpolation for smoother mesh.");
}

// tessellation params
Expand Down Expand Up @@ -111,7 +110,7 @@ void TessellationModePopup()
var mode = (TessellationMode)tessellationMode.floatValue;

EditorGUI.BeginChangeCheck();
mode = (TessellationMode)EditorGUILayout.Popup(Styles.tessellationModeStr, (int)mode, Styles.tessellationModeNames);
mode = (TessellationMode)EditorGUILayout.Popup(Styles.tessellationModeText, (int)mode, Styles.tessellationModeNames);
if (EditorGUI.EndChangeCheck())
{
materialEditor.RegisterPropertyChangeUndo("Tessellation Mode");
Expand Down