-
Notifications
You must be signed in to change notification settings - Fork 860
Fixed exposure not being properly handled in ray tracing performance (RTGI and RTR, case 1346383). #5068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! This comment will help you figure out which jobs to run before merging your PR. The suggestions are dynamic based on what files you have changed. HDRP Depending on the scope of your PR, you may need to run more jobs than what has been suggested. Please speak to your lead or a Graphics SDET (#devs-graphics-automation) if you are unsure. |
|
It appears that you made a non-draft PR! |
remi-chapelain
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has already been pair tested extensively.
Thanks for extending the coverage of the previous tests (added RTGI and high exposure that makes intensity values go over the buffer limit maximum value)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update this
|
Fixed comment and launched tests |
…(RTGI and RTR, case 1346383).
8d19c10 to
d7d2773
Compare
Original problem described here:
https://forum.unity.com/threads/feature-request-better-denoiser-for-gi.1132984/
Major fixes of this PR
Exposure is now properly handeled as well as exposure weight for materials.
Sky is always clamped in HSV space
All materials are clamped in RGB space for RTR
All materials are clamped in HSV for RTGI
A regression was introduced in this PR #4340

Added new tests to cover properly all the cases.
Testing status
The new tests pass locally.
Pair tested with @remi-chapelain