[2021.2] Fixing a shadow artefact on Terrain Detail objects #4447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
phi-lira
approved these changes
May 17, 2021
phocodes
approved these changes
May 27, 2021
# Conflicts: # com.unity.render-pipelines.universal/CHANGELOG.md # com.unity.render-pipelines.universal/Shaders/Terrain/TerrainDetailLitPasses.hlsl
com.unity.render-pipelines.universal/Shaders/Terrain/TerrainDetailLitPasses.hlsl
Outdated
Show resolved
Hide resolved
Contributor
Author
|
The yamato failure is known and already present on Master |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR fixes an issue with Shadow Artefacts appearing between cascades on Terrain Detail objects.
This video shows the Before/After difference
https://user-images.githubusercontent.com/225349/117161557-4bafb880-adc2-11eb-96ac-e3f806524b39.mov
What has been tested
Tested manually in the editor
Comments to reviewers
This is the same fix done in #112 except now in TerrainDetailLitPasses.hlsl.