[URP] Re-enable XR in test 146_Unlit_Custom_Shadows [skip ci] #4360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabien-unity
approved these changes
Apr 29, 2021
sophiaaar
changed the title
sophiaaar
changed the title
theopnv
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix for bug 1329080
The reason that the results for XR and non-XR tests of 146_Unlit_Custom_Shadows are different is because the --xr-tests argument on the XR job goes through a different rending path to the non-XR job. Enabling Back Buffer capture on the test in question resolves the difference between them.
Testing status
Comments to reviewers
Notes for the reviewers you have assigned.