Update DefaultCloudMap texture compression type to RGB(A) Compressed BC7 #4338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
Contributor
Author
|
Adding QA for awareness |
sebastienlagarde
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous format DXT|BC3 used introduced very noticeable compression artifacts which is reduced a lot if format is changed to BC7. This is especially noticeable when feather type clouds are in full opacity, but is quite clear with lower levels as well.
Master DXT5|BC3
PR BC7
With BC7 texture size remains 2MB same as it was before with DXT5|BC3
Updated CloudLayer ref images, relaunching yamato: https://yamato.cds.internal.unity3d.com/jobs/1485-Graphics/tree/hd%252FdefaultCloudLayerImageCompressionChange/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk/6527495/job/pipeline