Skip to content

Fix erroneous tile coordinate calculations in contact shadows #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Fix erroneous tile coordinate calculations in contact shadows #4335

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04249aa
Fix wrong tile coord calculations
FrancescoC-unity Apr 27, 2021
b4a5cc3
Changelog
FrancescoC-unity Apr 27, 2021
a1bc0bb
Update test scene for contact shadow to cover data
FrancescoC-unity Apr 28, 2021
24ce5f6
update references screenshots
sebastienlagarde Apr 29, 2021
98ba4e9
Merge branch 'hd/bugfix' into HDRP/fix-contact-shadow-tile-coord-calc…
sebastienlagarde Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed LightCluster debug view for ray tracing.
- Fixed issue with RAS build fail when LOD was missing a renderer
- Fixed an issue where sometime a docked lookdev could be rendered at zero size and break.
- Fixed contact shadows tile coordinates calculations.

### Changed
- Changed Window/Render Pipeline/HD Render Pipeline Wizard to Window/Rendering/HDRP Wizard
Expand Down
2 changes: 1 addition & 1 deletion com.unity.render-pipelines.high-definition/Runtime/Lighting/Shadow/ContactShadows.compute
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ void DeferredContactShadow(uint2 groupThreadId : SV_GroupThreadID, uint2 groupId

uint2 pixelCoord = groupId * DEFERRED_SHADOW_TILE_SIZE + groupThreadId;
// There might be a mismatch between the size of a tile and the group size of this shader.
uint2 tileCoord = groupId * (DEFERRED_SHADOW_TILE_SIZE / TILE_SIZE_FPTL);
uint2 tileCoord = (groupId * DEFERRED_SHADOW_TILE_SIZE) / (TILE_SIZE_FPTL);

#ifdef ENABLE_MSAA
float depth = LOAD_TEXTURE2D_X(_CameraDepthValues, pixelCoord.xy).z;
Expand Down