Disable Enlighten lightmapper for HDRP. #4326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
sebastienlagarde
approved these changes
Apr 27, 2021
iM0ve
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
I additionally tested what would happen if Enlighten is already selected before project upgrade.
No warnings or errors. If Enlighten is already selected then it will remain so. After switching to another lightmpapper you are not allowed to switch back to Enlighten. New projects wont be able to choose Enlighten. The change should be safe.
kroatoa
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
As enlighten has been revived in 21.2 it appears in the lightmapper choice. We don't want to allow its usage for baking so we needed to hide it in HDRP
https://jira.unity3d.com/browse/GFXGI-472
Testing status
Looked at the lighting settings and confirmed Enlighten was unavailable.