Added define for new reflection probe API update (case 1290521) #4323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
* Add null check * changelog
* Remove unneeded position from input layout of light cluster * Changelog Co-authored-by: sebastienlagarde <[email protected]>
…4313) * Skip adding the LOD's renderer to the checked renderer if it's null * changelog * Add LODgroup missing renderer to "check scene content for ray tracing" * formatting test * formatting Co-authored-by: sebastienlagarde <[email protected]>
…ind will be impacted (#4325) * Update doc * Fix doc
sebastienlagarde
approved these changes
Apr 27, 2021
* Fixed an issue where sometime a docked lookdev could be rendered at zero size and break. * Update changelog # Conflicts: # com.unity.render-pipelines.high-definition/CHANGELOG.md Co-authored-by: sebastienlagarde <[email protected]>
JulienIgnace-Unity
approved these changes
Apr 27, 2021
…fers (#4333) * Updated troubleshooting custom pass doc * Update Custom-Pass-Troubleshooting.md
…#4337) * Fixed an issue where runtime debug window UI would leak game objects. * Update changelog
Co-authored-by: Sebastien Lagarde <[email protected]>
… and view direction is near zero (#4342) Co-authored-by: sebastienlagarde <[email protected]>
* Fix ray tracing unlit emissive exposure. Changelog * Automated tests coverage * update scenes Co-authored-by: Remi Chapelain <[email protected]> Co-authored-by: sebastienlagarde <[email protected]>
… DRS is on. (#4346) * Fixing bad pyramid color source texture size. DRS hanlder must be queried since the mip levels depend on the source hardware resolution * Changelog Co-authored-by: sebastienlagarde <[email protected]>
TomasKiniulis
approved these changes
Apr 28, 2021
Contributor
TomasKiniulis
left a comment
TomasKiniulis
left a comment
There was a problem hiding this comment.
Checked HDRP Template project on latest trunk calling multiple On Demand probes. Seems good. No GC Allocs occur, probes remain to be updated correctly.
Contributor
|
Note to self: retarget to master once hd/bugfix is merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fixes 1290521.
GC memory allocation was performed because of a previous workaround.
Appropriate code is now enabled with a define starting from 2021.2.0a16 and there are no more GC memory allocated.
Testing status
PlayerLoop/ScriptableRuntimeReflectionSystemWrapper.Internal_ScriptableRuntimeReflectionSystemWrapper_TickRealtimeProbe(), it should allocate 81B of GC memory.Unity.RenderPipelines.HighDefinition.Runtimeasmdefthe defineREFLECTION_PROBE_UPDATE_CACHED_DATA_AVAILABLEmust be applied forUnitystarting from2021.2.0a16(this is what this PR is about)Comments to reviewers