Revert script changes to lighting test done in (#4182) #4321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cb7a96a.
|
It appears that you made a non-draft PR! |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Revert scripting changes made to lighting test. in PR #4182
This PR should add back scripting files to Editor and Runtime folders of project and remove reference to the testing package.
Testing status
Tested locally
Comments to reviewers
The reason to revert this files is because there's another PR that wants to add tests to the lighting project. When adding those for some reason an assembly with a different name from the one that was in the project before cause access issue to internal editor rendering assembly. I suspect this is related to some code giving access to internals to that specific assembly file that was on the project before and I couldn't figure out where.
Reverting so I unblock the other PR, this should be investigated imo later.